2024 Mar 08, 01:59 PM
The code change looks like it should work, if you need help testing let me know.
I have completed my testing and only found one issue, where I think we had a misunderstanding concerning the functionality of gv.rn. It does not make sense for the moisture_sensor_control plugin to have any influence on manual schedules, i.e. RUN NOW and RUN ONCE, however gv.rn is only set for RUN NOW and not for RUN ONCE. If you run a schedule manually it should not be blocked by a plugin.
Apart from this issue and the ones mentioned in the previous post as far as I'm concerned the pull request containing the moisture_sensor_data_mqtt and the moisture_sensor_control plugins can be merged.
I have completed my testing and only found one issue, where I think we had a misunderstanding concerning the functionality of gv.rn. It does not make sense for the moisture_sensor_control plugin to have any influence on manual schedules, i.e. RUN NOW and RUN ONCE, however gv.rn is only set for RUN NOW and not for RUN ONCE. If you run a schedule manually it should not be blocked by a plugin.
Apart from this issue and the ones mentioned in the previous post as far as I'm concerned the pull request containing the moisture_sensor_data_mqtt and the moisture_sensor_control plugins can be merged.