2024 Feb 06, 03:41 PM
(2024 Feb 05, 07:28 PM)dan Wrote: Yes, 1 changed to singular was intentional.
The old "stations_scheduled" seemed useless by returning "SIP".
I restored the old version for now along with the new version but the difference in names is too subtle.
Perhaps the new on should be named "one_station_scheduled"?
I would leave it at "station_scheduled" as to me this sums the signal up correctly. Once I worked out what had changed the actual code change was trivial. The old name is used by 5 official plugins so that would be an easy change too. Going forwards I would keep the old signal implementation in parallel to the new one but document it as deprecated and remove it in a future release - standard software engineering practice. That would give any unofficial plugin writers time to adapt.
Using your plugin concept I did not find it too hard to achieve my goal for the plugin and I'm more or less happy with the current state so I have created a draft pull request.
I did have one more optional item on my todo list which was to respect the Menu -> Settings -> Stations section -> Ignore Plugin adjustments? and to do this I would need to check gv.iw with something like:
board byte = station_index / gv.nst
station bit = station index % gv.nst
but as mentioned in my post https://nosack.com/sipforum/thread-320-p...ml#pid1658 I'm not convinced about the board/station logic.